From c10d376990e54e8b7cc698dfc0feb89ecafb85ee Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Sat, 20 Feb 2021 16:41:33 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt                | 5 ++---
 ayanova/src/api/form-custom-template.js | 6 +++++-
 ayanova/src/api/gzform.js               | 2 ++
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index 64f60ba4..f733195a 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -5,6 +5,8 @@
 
 ― Marcus Aurelius, Meditations 
 
+
+
 MISC ITEMS THAT CAME UP
 
 ## CLIENT MISC ITEMS
@@ -42,9 +44,6 @@ todo: WHEN HAVE WORKORDER FORM customer popup notes need to pop pop pop, forgot
 	However, I also find that incredibly annoying but I guess that's the point :)
 
 ## SERVER MISC ITEMS
-todo: In FormFieldReference there are fields that are default Required and can't be hidden, not sure if there is any reason to show them in the customization form
-	it would be cleaner if they just weren't there at all, definitely in the spirit of more whitespace
-	investigate if there is any bit of code that relies on them even when not there (maybe datalist grid stuff? not sure)
 
 todo: OOPS, FormFieldReference has a potentially major issue:
 	RequiredFieldsValidator expects the FieldKey property to be the exact name of the business object property, but I've been just tossing anything in there willy nilly
diff --git a/ayanova/src/api/form-custom-template.js b/ayanova/src/api/form-custom-template.js
index 8046d125..d84e537c 100644
--- a/ayanova/src/api/form-custom-template.js
+++ b/ayanova/src/api/form-custom-template.js
@@ -16,7 +16,11 @@ function addDataKeyNames(obj) {
 }
 
 export default {
-  // cache the form customization data if it's not already present
+  ////////////////////////////////
+  // Cache the form customization data if it's not already present
+  // NOTE: FORM KEY **MUST** BE THE AYATYPE NAME WHERE POSSIBLE, IF NO TYPE THEN AN EXCEPTION NEEDS TO BE CODED IN
+  //SERVER FormFieldReference.cs -> public static List<string> FormFieldKeys
+  //
   async get(formKey) {
     if (
       !window.$gz.util.has(window.$gz.store.state.formCustomTemplate, formKey)
diff --git a/ayanova/src/api/gzform.js b/ayanova/src/api/gzform.js
index 0a08e84f..37b56026 100644
--- a/ayanova/src/api/gzform.js
+++ b/ayanova/src/api/gzform.js
@@ -691,6 +691,8 @@ export default {
   // NOTE: that in a form this should only be used with non stock-required fields, if they are already required they cannot be hidden
   //
   showMe(vm, formCustomTemplateFieldName) {
+    //TODO: CHILD COLLECTION MOD handle dot notation path indexed collection etc
+    // possibly it will just work since the key will match but double check
     //special check for wiki field
     //if read only then can't add any content and if no content then no reason to show it at all
     if (formCustomTemplateFieldName == "wiki") {