From ae79d68770758d9d4e6bcb6dc68a26f329bc9970 Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Sat, 20 Aug 2022 18:15:27 +0000
Subject: [PATCH] Cleanup misc es-lint disablements not required, removed dev
 mode manually set flag for better NODE_ENV built in flag which avoids
 potentially forgetting to remove that in production builds.

---
 ayanova/src/App.vue                         |  1 -
 ayanova/src/api/authorizationroles.js       |  3 +--
 ayanova/src/api/gzapi.js                    |  2 +-
 ayanova/src/components/currency-control.vue |  1 -
 ayanova/src/components/report-control.vue   |  2 --
 ayanova/src/main.js                         | 15 ++-------------
 ayanova/src/views/ops-profile.vue           |  2 +-
 ayanova/src/views/svc-schedule.vue          |  1 -
 8 files changed, 5 insertions(+), 22 deletions(-)

diff --git a/ayanova/src/App.vue b/ayanova/src/App.vue
index 6f734228..5707b4cf 100644
--- a/ayanova/src/App.vue
+++ b/ayanova/src/App.vue
@@ -343,7 +343,6 @@ export default {
     if (!vm.$store.state.authenticated && !isReset) {
       //If a direct open path was being used but user is not logged in this will catch it
       //otherwise they will just go on to that path directly
-      // eslint-disable-next-line no-debugger
 
       if (toPath != undefined) {
         vm.$router.push({
diff --git a/ayanova/src/api/authorizationroles.js b/ayanova/src/api/authorizationroles.js
index a846ee89..65de57cf 100644
--- a/ayanova/src/api/authorizationroles.js
+++ b/ayanova/src/api/authorizationroles.js
@@ -49,8 +49,7 @@ export default {
       return false;
     }
     //array form?
-    // eslint-disable-next-line no-debugger
-    debugger;
+
     if (Array.isArray(desiredRole)) {
       //it's an array of roles, iterate and if any are present then return true
       for (let i = 0; i < desiredRole.length; i++) {
diff --git a/ayanova/src/api/gzapi.js b/ayanova/src/api/gzapi.js
index 2a995e9b..e809cb61 100644
--- a/ayanova/src/api/gzapi.js
+++ b/ayanova/src/api/gzapi.js
@@ -435,7 +435,7 @@ export default {
   //
   doDelayAsync: () => {
     // eslint-disable-next-line
-    return new Promise((resolve) => {
+    return new Promise(resolve => {
       setTimeout(() => resolve("I did something"), 10000);
     });
   },
diff --git a/ayanova/src/components/currency-control.vue b/ayanova/src/components/currency-control.vue
index cc4fcb72..9d9816fc 100644
--- a/ayanova/src/components/currency-control.vue
+++ b/ayanova/src/components/currency-control.vue
@@ -19,7 +19,6 @@
   </div>
 </template>
 <script>
-/*  Xeslint-disable //@click:append-outer="appendOuter"  */
 //https://dm4t2.github.io/vue-currency-input/guide/#introduction :value="formattedValue"
 //https://codesandbox.io/s/vue-template-kd7d1?fontsize=14&module=%2Fsrc%2FApp.vue
 //https://github.com/dm4t2/vue-currency-input
diff --git a/ayanova/src/components/report-control.vue b/ayanova/src/components/report-control.vue
index c482b79d..cf7d54b3 100644
--- a/ayanova/src/components/report-control.vue
+++ b/ayanova/src/components/report-control.vue
@@ -166,8 +166,6 @@ export default {
           //check for any terminal status
           if (jobStatus != 1 && jobStatus != 2) {
             this.jobActive = false;
-            // // eslint-disable-next-line no-debugger
-            // debugger;
             const jobLogRes = await window.$gz.api.get(
               `job-operations/logs/${jobId}`
             );
diff --git a/ayanova/src/main.js b/ayanova/src/main.js
index f8674ce3..15cfc7b2 100644
--- a/ayanova/src/main.js
+++ b/ayanova/src/main.js
@@ -60,17 +60,6 @@ import chartLineControl from "./components/chart-line-control.vue";
 import chartBarControl from "./components/chart-bar-control.vue";
 import chartBarHorizontalControl from "./components/chart-bar-horizontal-control.vue";
 
-//**************************************************************
-//**************************************************************
-//**************************************************************
-//DEVELOPMENT MODE FLAG, SET FALSE FOR RELEASE
-//************************************************************
-const DEV_MODE = false;
-//************************************************************
-//**************************************************************
-//**************************************************************
-//**************************************************************
-
 /////////////////////////////////////////////////////////////////
 // LIBS AND GLOBAL ITEMS
 //
@@ -93,7 +82,7 @@ window.$gz = {
   errorHandler: errorhandler,
   store: store,
   clientInfo: ayaNovaVersion,
-  dev: DEV_MODE
+  dev: process.env.NODE_ENV === "development"
 };
 
 /////////////////////////////////////////////////////////////////
@@ -209,7 +198,7 @@ Vue.directive("focus", {
 //
 Vue.prototype.$ay = {
   //development mode, development level error messages etc
-  dev: DEV_MODE,
+  dev: process.env.NODE_ENV === "development",
   t: function(tKey) {
     return translation.get(tKey);
   },
diff --git a/ayanova/src/views/ops-profile.vue b/ayanova/src/views/ops-profile.vue
index 42d6f447..3e5c2c77 100644
--- a/ayanova/src/views/ops-profile.vue
+++ b/ayanova/src/views/ops-profile.vue
@@ -64,7 +64,7 @@ export default {
 
     refreshProfile() {
       const ifr = document.getElementById("profileFrame");
-      //trigger refresh?  wtf?
+      //trigger refresh?  wtf? I don't know and at this point I'm not changing it in case it breaks something 2022-08-20
       // eslint-disable-next-line no-self-assign
       ifr.src = ifr.src;
     }
diff --git a/ayanova/src/views/svc-schedule.vue b/ayanova/src/views/svc-schedule.vue
index 73b0802d..4fe790fb 100644
--- a/ayanova/src/views/svc-schedule.vue
+++ b/ayanova/src/views/svc-schedule.vue
@@ -376,7 +376,6 @@
   </div>
 </template>
 <script>
-/* eslint-disable no-debugger */
 const FORM_KEY = "svc-schedule";
 import GZDaysOfWeek from "../components/days-of-week-control.vue";
 export default {