From 8df2b7f614978ce41a575556fdad5545ba7aaac7 Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Tue, 8 Sep 2020 22:53:19 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt                       | 7 ++++++-
 ayanova/src/views/ay-report-edit.vue           | 6 ++++++
 ayanova/src/views/home-notify-subscription.vue | 8 ++++----
 3 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index 035ac7e8..b4e151fc 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -20,7 +20,12 @@ todo: think about gz-error box and  v-if="formState.ready"
 	error can't show if form fails to init for some reason!
 	or maybe it can because it's set to show in case of error during init
 
-
+todo: need to be able to have a link system whereby a user can directly open a report from an object via one link after login
+	just like how you can open a specific widget from a url link, but to extend that there is also a report parameter and it triggers
+	the ui to first open the object then populate it from the report
+	Maybe a report viewer page after all or phantom link with no page that just opens the report directly as if the user had gone through the objects edit form
+	Maybe even a report viewer URL that is based off the server and they never actually use the full client software?
+		meh
 
 
 REPORTING
diff --git a/ayanova/src/views/ay-report-edit.vue b/ayanova/src/views/ay-report-edit.vue
index 8e2dd320..2fd23686 100644
--- a/ayanova/src/views/ay-report-edit.vue
+++ b/ayanova/src/views/ay-report-edit.vue
@@ -136,6 +136,9 @@ import * as monaco from "monaco-editor";
 
 /*TODO:
 
+Executive decision, no longer attach reports to emails...ever.  User must log in 
+  this is to avoid a lot of fragile code but also for:
+  Security, email hassle avoidance (attachments increasingly failing), etc etc
 
 
 determine course of action to handle locale keys list for report based on fields in data source
@@ -155,6 +158,9 @@ Make up sample reports for widget that show off the basics including logo etc
 
 make them auto generate (import from files?) with sample data in seeder
 
+"tab" button color doesn't follow pre-defined colors, use highlight instead
+also make the data tab button grayer looking so it's clearer that it's different than the rest
+
 Make a working template with api methods being called
   api helper js injected to work with api methods, automatically uses the bearer token in client meta data
   export as example and also document
diff --git a/ayanova/src/views/home-notify-subscription.vue b/ayanova/src/views/home-notify-subscription.vue
index ef25ddda..6bb58fff 100644
--- a/ayanova/src/views/home-notify-subscription.vue
+++ b/ayanova/src/views/home-notify-subscription.vue
@@ -112,7 +112,7 @@
               ></v-text-field>
             </v-col>
 
-            <v-col v-if="showAttachReportId" cols="12" sm="6" lg="4" xl="3">
+            <v-col v-if="showLinkReportId" cols="12" sm="6" lg="4" xl="3">
               ATTACH REPORT todo: dynamic list of reports to select from for
               type chosen
             </v-col>
@@ -227,7 +227,7 @@ export default {
         [Required]
         public NotifyDeliveryMethod DeliveryMethod { get; set; }
         public string DeliveryAddress { get; set; }
-        public long? AttachReportId { get; set; }
+        public long? LinkReportId { get; set; }
         public List<string> tags { get; set; }*/
       obj: {
         id: 0,
@@ -240,7 +240,7 @@ export default {
         decValue: 0,
         deliveryMethod: 0,
         deliveryAddress: null,
-        attachReportId: 0,
+        linkReportId: 0,
         tags: []
       },
 
@@ -349,7 +349,7 @@ export default {
           return false;
       }
     },
-    showAttachReportId() {
+    showLinkReportId() {
       //TODO: Many others as well, but for now until those objects exist
       switch (this.obj.eventType) {
         case 27: //General notification