From 89fabfe3fd115c2b7ea6dcdf325d9b565ff1e806 Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Thu, 29 Apr 2021 18:36:31 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt                      |  2 --
 ayanova/src/api/gzform.js                     | 11 +++++++--
 ayanova/src/components/currency-control.vue   | 24 +++++++++++++++++--
 ayanova/src/components/decimal-control.vue    |  5 +++-
 ayanova/src/components/percent-control.vue    | 11 ++++++++-
 .../work-order-item-scheduled-users.vue       |  1 +
 6 files changed, 46 insertions(+), 8 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index cfa40056..0fa6ec38 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -301,8 +301,6 @@ todo: cypress testing for load testing etc
 	then make new project folder for this and put the tests there
 	install standalone cypress and go it without vue stuff
 	
-todo: when fetchign a workorder it should order by woitem.sequence so that reports and things automatically get it in sequence
-	I think in ui it orders automatically at the ui itself in sequence but would need that for reports as well.
 
 todo: changing scheduser estimated qty doesn't trigger dirty until move off, is it using the wrong event for update?
 	gz-decimal control
diff --git a/ayanova/src/api/gzform.js b/ayanova/src/api/gzform.js
index 6e7d1ff7..c6d5cc3c 100644
--- a/ayanova/src/api/gzform.js
+++ b/ayanova/src/api/gzform.js
@@ -811,8 +811,15 @@ export default {
     }
 
     //dev error on form?
-    if (!formControl) {
-      throw `gzform::fieldValueChanged formControl is not found ref:${ref}, formReferences:${formReference} `;
+    if (formControl == null) {
+      if (vm.$ay.dev) {
+        //not necessarily an error, can happen during form init
+        console.trace(
+          `gzform::fieldValueChanged formControl is not found ref:${ref}, formReferences:${formReference} `
+        );
+      } else {
+        return;
+      }
     }
 
     //this is currently required to ensure that this method runs after all the broken rule checks have settled
diff --git a/ayanova/src/components/currency-control.vue b/ayanova/src/components/currency-control.vue
index 32389788..cd79d23a 100644
--- a/ayanova/src/components/currency-control.vue
+++ b/ayanova/src/components/currency-control.vue
@@ -3,7 +3,7 @@
     <v-text-field
       ref="textField"
       :value="currencyValue"
-      @change="updateValue"
+      @input="updateValue"
       v-currency="{
         currency: currencyName,
         locale: languageName
@@ -29,7 +29,8 @@ export default {
   data() {
     return {
       currencyName: window.$gz.locale.getCurrencyName(),
-      languageName: window.$gz.locale.getResolvedLanguage()
+      languageName: window.$gz.locale.getResolvedLanguage(),
+      initializing: true
     };
   },
   props: {
@@ -48,11 +49,30 @@ export default {
   },
   methods: {
     updateValue() {
+      //this is required because the initial setting triggers an input event
+      //however the two values differ because it comes from the server in much higher precision
+      //and this control rounds it down
+      //so the first trigger must be ignored until it "settles"
+      if (this.initializing) {
+        this.initializing = false;
+        return;
+      }
       let val = this.$refs.textField.$refs.input.value;
+      // //_value contains the actual underlying numeric value without text
+      // //value contains the entered text
+      // if (this.$refs.textField.$refs.input._value == this.value) {
+      //   return;
+      // }
       let parsedValue = parseCurrency(val, {
         currency: this.currencyName,
         locale: this.languageName
       });
+
+      // //this.value on init is a very long string of digits / decimal places triggering a variance once rounded
+      // let parsedOldValue = parseCurrency(this.value.toString(), {
+      //   currency: this.currencyName,
+      //   locale: this.languageName
+      // });
       if (parsedValue != this.value) {
         this.$emit("input", parsedValue);
       }
diff --git a/ayanova/src/components/decimal-control.vue b/ayanova/src/components/decimal-control.vue
index 49c49721..ab410286 100644
--- a/ayanova/src/components/decimal-control.vue
+++ b/ayanova/src/components/decimal-control.vue
@@ -3,7 +3,7 @@
     <v-text-field
       ref="textField"
       :value="currencyValue"
-      @change="updateValue"
+      @input="updateValue"
       v-currency="{
         currency: null,
         locale: languageName,
@@ -52,6 +52,9 @@ export default {
         currency: null,
         locale: this.languageName
       });
+      if (parsedValue == this.value) {
+        return;
+      }
 
       this.$emit("input", parsedValue);
     }
diff --git a/ayanova/src/components/percent-control.vue b/ayanova/src/components/percent-control.vue
index 49c0c484..ea3b004e 100644
--- a/ayanova/src/components/percent-control.vue
+++ b/ayanova/src/components/percent-control.vue
@@ -3,7 +3,7 @@
     <v-text-field
       ref="textField"
       :value="currencyValue"
-      @change="updateValue"
+      @input="updateValue"
       v-currency="{
         currency: null,
         locale: languageName,
@@ -54,6 +54,15 @@ export default {
         locale: this.languageName
       });
 
+      if (parsedValue == this.value) {
+        return;
+      }
+
+      // console.log("PCT CONTROL:", {
+      //   parsedValue: parsedValue,
+      //   value: this.value
+      // });
+
       this.$emit("input", parsedValue);
     }
   }
diff --git a/ayanova/src/components/work-order-item-scheduled-users.vue b/ayanova/src/components/work-order-item-scheduled-users.vue
index ba6b30ca..74b8f3b8 100644
--- a/ayanova/src/components/work-order-item-scheduled-users.vue
+++ b/ayanova/src/components/work-order-item-scheduled-users.vue
@@ -185,6 +185,7 @@ export default {
       return window.$gz.form;
     },
     fieldValueChanged(ref) {
+      console.log("woitemscheduserform, field value changed", ref);
       if (!this.formState.loading && !this.formState.readonly) {
         //flag this record dirty so it gets picked up by save
         this.value.items[this.activeWoItemIndex].scheduledUsers[