From 859d54f3b542af7909daeeeb29e3d520e9e8c007 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Fri, 27 Nov 2020 16:14:14 +0000 Subject: [PATCH] --- ayanova/devdocs/rando-todo.txt | 11 ++++++++++- ayanova/devdocs/todo.txt | 13 ++++++++++--- ayanova/src/api/gzapi.js | 3 ++- 3 files changed, 22 insertions(+), 5 deletions(-) diff --git a/ayanova/devdocs/rando-todo.txt b/ayanova/devdocs/rando-todo.txt index 70f2b895..e01053ea 100644 --- a/ayanova/devdocs/rando-todo.txt +++ b/ayanova/devdocs/rando-todo.txt @@ -97,4 +97,13 @@ todo: ON HOLD TIL LATER Lagging typing in name field on customize form for data Pick through and replace function calls in UI with computed properties bit by bit and see what happens Several collections bound to array in data object, is that array changing on typing text? Triggering something? Should it be bound to a computed getter instead of directly to the data object? - \ No newline at end of file + + + +todo: erasedatabase for import causes a conflict with client cached settings like listview etc + Noticed it when v8 migrate and superuser account getting error about missing datalistview when reviewing imported data + was easy to just switch to the default view and force it to reset for that grid so not life or death issue for sure + Client needs to also erase it's cache, but how will it know? + Maybe not a significant issue, if needs addressing look into a flag of some kind, maybe a version match or something + but considering how rare this would be outside of onboarding etc I'm inclined to maybe say fuck it. + Best solution probably when client sees something it expects to be at server is missing to trigger a reset process \ No newline at end of file diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt index 29c968e6..5d6876bb 100644 --- a/ayanova/devdocs/todo.txt +++ b/ayanova/devdocs/todo.txt @@ -37,9 +37,6 @@ MISC ITEMS THAT CAME UP -todo: erasedatabase for import needs to also erase datalistview's and defaults or has an issue with them - I think maybe actually it already deletes them but it needs to set the SuperUser account to not use them - because after import I see errors related to missing datalistview when logged in as su and viewing import data todo: import items triggers notification checks since they are going through the regular create process e.g. this throws up all the time during v8 migrate: throw new System.NotImplementedException("Awaiting workorder object completion"); @@ -50,6 +47,14 @@ todo: import items triggers notification checks since they are going through the also import export code, should it trigger notification? If a user imports a bunch of clients from a json file and they happen to have a notification set for create client then could get thousands of notifications + TRICKY, possible resolution: + something flagged on the login session only and must be superuser for mass import + so maybe an extra flag during auth indicating mass change session, i.e. user logs in with special route or parameter + server provides jwt for session that contains a flag to not do notifications? + + Or, a skip_notify header that only the superuser can add to their api calls, server sees it and sets it for that specific op only? + can a header be seen at the level of process notifyevent? + todo: network error should not show on NEW COUNT for notifications because it's looping over and over and keeps showing that error That particular code should just show the error once maybe then go about it's business quietly? or maybe it's kosher as is, a dev environment is not the same as production after all @@ -94,6 +99,8 @@ todo: search form weirdness TYPE NAMES results for some type names show as "type 59" for example instead of "Customer note" +todo: notification queue? Is there a need for a form where can see all queued notifications and delete them or something in case of issues? + or maybe just a single clear it all out button? todo: TEST ON SERVER CUSTOMER STUFF ............................................................ diff --git a/ayanova/src/api/gzapi.js b/ayanova/src/api/gzapi.js index 62b7754d..55d3f3c9 100644 --- a/ayanova/src/api/gzapi.js +++ b/ayanova/src/api/gzapi.js @@ -243,7 +243,8 @@ export default { return { Accept: "application/json", "Content-Type": "application/json", - Authorization: "Bearer " + window.$gz.store.state.apiToken + Authorization: "Bearer " + window.$gz.store.state.apiToken, + "X-AY-Import-Mode": true }; }, postUnAuthorizedHeaders() {