diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt index 6967ab05..b9e31573 100644 --- a/ayanova/devdocs/todo.txt +++ b/ayanova/devdocs/todo.txt @@ -342,6 +342,18 @@ todo: DataList view and filter are combined and this is wrong todo: DataList - there are a bunch of props being set that don't exist, for example currentListViewId, dataListFilter, dataListSort remove them with impunity + + +** IMPORTANT todo: double check concurrency code with Customer or Project just to be sure, it has been changed but not sure if it was ever properly tested. + This bit is concerning in controller: + if (biz.Errors.Exists(z => z.Code == ApiErrorCode.CONCURRENCY_CONFLICT)) + return StatusCode(409, new ApiErrorResponse(biz.Errors)); + else + return BadRequest(new ApiErrorResponse(biz.Errors)); + And the new ct.Replace(dbObject, putObject); being used in put*biz is also concerning + in the old code it would specifically have to set the concurrency value + Need to thoroughly check it's working as it should + todo: userbiz validate can delete has funky error todo: bugbug filter on a phone number field results in error at server as unsupported type make sure all types are supported @@ -429,6 +441,8 @@ todo: 2fa is going to be an absolute must have pretty soon, look into what's inv todo: if a menu item has no icon, can it be shown to the left and exclude the space taken up by the icon? see CSR form for example + + todo: test errors on widget form for all controls Have a way of telling the server on an update to return all the errors for all the fields possible as well as server generalerror this way can see at a glance that all the controls are properly displaying their errrors