From 7a09671bec0c529c53a164fb66432888f8f0f683 Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Thu, 17 Sep 2020 15:25:06 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt    | 50 ++++++++++++++++++-------------------
 ayanova/src/views/login.vue |  2 +-
 2 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index 2a5225a6..5ab1c24a 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -2,21 +2,20 @@
 @@@@@@@@@@@@@@@ ROADMAP STAGE 4 - REPORTING / DASHBOARD / KPI
 @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
 
+TODO:  Report
 
-todo: Exceptions don't show "Name: Error," ever
-todo: NON DEV MODE
-	No stack trace in error messages!
-	But do keep stack trace in internal LOG for diagnosis
+- Server Render Timeout
+		handle timeout waiting for report (infinite loop scenario?)
+		make report that has an infinite loop then have it timeout at the server properly and return clean error timeout
+		Possibly add a property to the report to force a longer than default timeout?
+			useful for edge cases in the wild to have at hand
+		maybe this:
+			https://jeremylindsayni.wordpress.com/2016/05/28/how-to-set-a-maximum-time-to-allow-a-c-function-to-run-for/
 
-todo: when server down get this weird TypeError string at client: 
-"Could not connect to AyaNova server at http://localhost:7575/api/v8.0/
-Error: TypeError: NetworkError when attempting to fetch resource."
+		Have asked on stackoverflow
+		 hardkoded replied himself and said use waitforexpression https://stackoverflow.com/questions/63929479/timeout-with-evaluateexpressionasync/63937743#63937743
+		https://pptr.dev/
 
-todo: a script error when just running a report from the report selector acts weird
-	Test with dev mode off to confirm it won't show it in the UI
-	Should show the error in the UI
-
-TODO:  Report confirmation checklist
 	- page breaks properly EXAMPLE NEEDED
 		this is the current CSS property, not the one jsreport was using: https://developer.mozilla.org/en-US/docs/Web/CSS/break-before		
 		There are many options including ones for columns and some to prevent page breaks splitting up blocks.
@@ -30,26 +29,27 @@ TODO:  Report confirmation checklist
 	- print properties in css ref: https://www.tutorialspoint.com/css/css_print_references.htm
 		@page https://developer.mozilla.org/en-US/docs/Web/CSS/@page
 
-	- custom extra javascript functions EXAMPLE NEEDED			
+
+
+
+
+	- custom extra javascript functions EXAMPLE NEEDED
+
 	- Mailing labels
+		if a hassle can skip, it's an unusual thing probably today and users could export to open office then print or whathaveyou
+
+
 	- Alternate paper sizes A4, Letter etc
 		https://developer.mozilla.org/en-US/docs/Web/CSS/@page/size
 
 	- Helper for datalist filter human readable
 		also useful for the UI of the datalist as well
 
-	- Reports on each type of data anticipated
-	- Graphs / KP / METRICS needs to print likely
-	- Security of scripts / scrubbing or sandboxing
-		make sure can't access file system at server with a malicious report
-	- logging
-		log errors, handlebars template errors, javascript errors etc
-	- timeout
-		handle timeout waiting for report (infinite loop scenario?)
-	- Minimize ay-report.js?
-		doesn't download so, likely a waste of time to worry about minimizing it unless it speeds up performance to some noticeable degree
-
+	
 
+	- readable errors:
+		https://stackoverflow.com/questions/56959242/how-do-i-get-readable-browser-page-errors-out-of-puppeteer-sharp
+	
 -------- NON REPORTING RELATED STUFF ---------------
 todo: Open source credit area in UI
 	acknowledgements etc
@@ -102,7 +102,7 @@ todo: DASHBOARD
 	- these cases:
 		https://rockfish.ayanova.com/default.htm#!/rfcaseEdit/2024
 		https://rockfish.ayanova.com/default.htm#!/rfcaseEdit/1974
-
+	- Printable, need to test render these same metrics graphs in reports
 
  
 @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
diff --git a/ayanova/src/views/login.vue b/ayanova/src/views/login.vue
index e42bf796..7e1c0da2 100644
--- a/ayanova/src/views/login.vue
+++ b/ayanova/src/views/login.vue
@@ -370,7 +370,7 @@ export default {
             if (
               msg.includes("NetworkError") ||
               msg.includes("Failed to fetch")
-            ) {              
+            ) {
               msg =
                 "Could not connect to AyaNova server at " +
                 window.$gz.api.APIUrl("") +