From 77c4ec1fb9f7117358e51d01ba5e400a57d70d44 Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Tue, 1 Jun 2021 18:14:08 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt                            |  8 +++++++-
 ayanova/src/components/work-order-item-expenses.vue | 12 ++++++------
 ayanova/src/components/work-order-item-labors.vue   | 13 +++++++------
 ayanova/src/components/work-order-item-loans.vue    | 13 +++++++------
 .../components/work-order-item-outside-services.vue | 13 +++++--------
 .../components/work-order-item-part-requests.vue    | 11 +++++------
 ayanova/src/components/work-order-item-parts.vue    | 13 +++++++------
 .../components/work-order-item-scheduled-users.vue  | 13 +++++++------
 ayanova/src/components/work-order-item-tasks.vue    | 13 +++++++------
 ayanova/src/components/work-order-item-travels.vue  | 11 +++++------
 ayanova/src/components/work-order-item-units.vue    | 13 +++++++------
 ayanova/src/components/work-order-items.vue         | 13 ++++++++-----
 12 files changed, 78 insertions(+), 68 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index 30dba7d6..b8ba54b1 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -377,7 +377,10 @@ TODO: V7 features on wo I haven't coded yet
 
 	ServiceBank
 		any of it
-	
+
+bugbug: empty collection, save, add new item but don't save then click on delete and save and it all goes weird
+	on save, it seems to be trying to save the newly added but deleted record when it should just remove it and get on with it
+
 todo: workorderitemlabor new record stop date sb +1 hour
 
 todo: stop hiding one line tables in wo form, need them for the extra ui stuff they bring
@@ -386,6 +389,9 @@ todo: stop hiding one line tables in wo form, need them for the extra ui stuff t
 todo: mark for deletion with ONE record and no table?? how does that work?
 	keeping a single row as for above would help with this
 
+todo: no data available not localized in tables, not an issue if don't show when none, but is if do
+todo: in german (maybe others) noticed price viz fields not available translations so shows ??ListPrice for example
+
 todo: LoanUnit edit form add "*Cost" fields to UI
 todo: part request 
 	link to open po, delete button in grid? both?
diff --git a/ayanova/src/components/work-order-item-expenses.vue b/ayanova/src/components/work-order-item-expenses.vue
index 63845600..01e11b29 100644
--- a/ayanova/src/components/work-order-item-expenses.vue
+++ b/ayanova/src/components/work-order-item-expenses.vue
@@ -5,7 +5,7 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2"
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
                 >$ayiMoneyBillWave</v-icon
               >
               {{ $ay.t("WorkOrderItemExpenseList") }}
@@ -37,7 +37,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -72,8 +72,7 @@
             </template>
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -722,9 +721,10 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].expenses.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
+
     canAdd: function() {
       return this.pvm.rights.change && this.pvm.subRights.expenses.create;
     },
diff --git a/ayanova/src/components/work-order-item-labors.vue b/ayanova/src/components/work-order-item-labors.vue
index 1369a8fa..16821cb6 100644
--- a/ayanova/src/components/work-order-item-labors.vue
+++ b/ayanova/src/components/work-order-item-labors.vue
@@ -5,7 +5,9 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2">$ayiHammer</v-icon>
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
+                >$ayiHammer</v-icon
+              >
               {{ $ay.t("WorkOrderItemLaborList") }}
               <v-btn v-if="!parentDeleted" large icon v-bind="attrs" v-on="on">
                 <v-icon small color="primary">$ayiEllipsisV</v-icon>
@@ -35,7 +37,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -57,8 +59,7 @@
           >
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -797,8 +798,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].labors.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     canAdd: function() {
       return this.pvm.rights.change && this.pvm.subRights.labors.create;
diff --git a/ayanova/src/components/work-order-item-loans.vue b/ayanova/src/components/work-order-item-loans.vue
index 0229dd5b..8147a5c5 100644
--- a/ayanova/src/components/work-order-item-loans.vue
+++ b/ayanova/src/components/work-order-item-loans.vue
@@ -5,7 +5,9 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2">$ayiPlug</v-icon>
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
+                >$ayiPlug</v-icon
+              >
               {{ $ay.t("WorkOrderItemLoanList") }}
               <v-btn v-if="!parentDeleted" large icon v-bind="attrs" v-on="on">
                 <v-icon small color="primary">$ayiEllipsisV</v-icon>
@@ -35,7 +37,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -57,8 +59,7 @@
           >
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -820,8 +821,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].loans.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     canAdd: function() {
       return this.pvm.rights.change && this.pvm.subRights.loans.create;
diff --git a/ayanova/src/components/work-order-item-outside-services.vue b/ayanova/src/components/work-order-item-outside-services.vue
index 27a985e4..25242e36 100644
--- a/ayanova/src/components/work-order-item-outside-services.vue
+++ b/ayanova/src/components/work-order-item-outside-services.vue
@@ -5,7 +5,7 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2"
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
                 >$ayiLuggageCart</v-icon
               >
               {{ $ay.t("WorkOrderItemOutsideServiceList") }}
@@ -37,7 +37,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -59,8 +59,7 @@
           >
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -1025,10 +1024,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return (
-        this.value.items[this.activeWoItemIndex].outsideServices.length > 1
-      );
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     canAdd: function() {
       return (
diff --git a/ayanova/src/components/work-order-item-part-requests.vue b/ayanova/src/components/work-order-item-part-requests.vue
index 0bfc25ea..c6d4a110 100644
--- a/ayanova/src/components/work-order-item-part-requests.vue
+++ b/ayanova/src/components/work-order-item-part-requests.vue
@@ -5,7 +5,7 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2"
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
                 >$ayiParachuteBox</v-icon
               >
               {{ $ay.t("WorkOrderItemPartRequestList") }}
@@ -31,7 +31,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -59,8 +59,7 @@
             </template>
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -380,8 +379,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].partRequests.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     // canAdd: function() {
     //   return this.pvm.rights.change && this.pvm.subRights.partRequests.create;
diff --git a/ayanova/src/components/work-order-item-parts.vue b/ayanova/src/components/work-order-item-parts.vue
index ff4d2739..74887cfe 100644
--- a/ayanova/src/components/work-order-item-parts.vue
+++ b/ayanova/src/components/work-order-item-parts.vue
@@ -5,7 +5,9 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2">$ayiBoxes</v-icon>
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
+                >$ayiBoxes</v-icon
+              >
               {{ $ay.t("WorkOrderItemPartList") }}
               <v-btn v-if="!parentDeleted" large icon v-bind="attrs" v-on="on">
                 <v-icon small color="primary">$ayiEllipsisV</v-icon>
@@ -35,7 +37,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -57,8 +59,7 @@
           >
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -682,8 +683,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].parts.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     canAdd: function() {
       return this.pvm.rights.change && this.pvm.subRights.parts.create;
diff --git a/ayanova/src/components/work-order-item-scheduled-users.vue b/ayanova/src/components/work-order-item-scheduled-users.vue
index f16cd20b..10ce5f49 100644
--- a/ayanova/src/components/work-order-item-scheduled-users.vue
+++ b/ayanova/src/components/work-order-item-scheduled-users.vue
@@ -5,7 +5,9 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2">$ayiUserClock</v-icon>
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
+                >$ayiUserClock</v-icon
+              >
               {{ $ay.t("WorkOrderItemScheduledUserList") }}
               <v-btn v-if="!parentDeleted" large icon v-bind="attrs" v-on="on">
                 <v-icon small color="primary">$ayiEllipsisV</v-icon>
@@ -35,7 +37,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ################################ SCHEDULED USERS TABLE ############################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -57,8 +59,7 @@
           >
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -520,8 +521,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].scheduledUsers.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     canAdd: function() {
       return this.pvm.rights.change && this.pvm.subRights.scheduledUsers.create;
diff --git a/ayanova/src/components/work-order-item-tasks.vue b/ayanova/src/components/work-order-item-tasks.vue
index a64f1583..1b0917dc 100644
--- a/ayanova/src/components/work-order-item-tasks.vue
+++ b/ayanova/src/components/work-order-item-tasks.vue
@@ -5,7 +5,9 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2">$ayiTasks</v-icon>
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
+                >$ayiTasks</v-icon
+              >
               {{ $ay.t("WorkOrderItemTasks") }}
               <v-btn v-if="!parentDeleted" large icon v-bind="attrs" v-on="on">
                 <v-icon small color="primary">$ayiEllipsisV</v-icon>
@@ -42,7 +44,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -64,8 +66,7 @@
           >
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -579,8 +580,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].tasks.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     canAdd: function() {
       return this.pvm.rights.change && this.pvm.subRights.tasks.create;
diff --git a/ayanova/src/components/work-order-item-travels.vue b/ayanova/src/components/work-order-item-travels.vue
index 1e835361..5db8ea34 100644
--- a/ayanova/src/components/work-order-item-travels.vue
+++ b/ayanova/src/components/work-order-item-travels.vue
@@ -5,7 +5,7 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2"
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
                 >$ayiTruckMonster</v-icon
               >
               {{ $ay.t("WorkOrderItemTravelList") }}
@@ -37,7 +37,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -59,8 +59,7 @@
           >
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -799,8 +798,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].travels.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     canAdd: function() {
       return this.pvm.rights.change && this.pvm.subRights.travels.create;
diff --git a/ayanova/src/components/work-order-item-units.vue b/ayanova/src/components/work-order-item-units.vue
index b4c0e87f..78ee6ae8 100644
--- a/ayanova/src/components/work-order-item-units.vue
+++ b/ayanova/src/components/work-order-item-units.vue
@@ -5,7 +5,9 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h6">
-              <v-icon large color="primary" class="mr-2">$ayiFan</v-icon>
+              <v-icon large :color="hasData ? 'primary' : null" class="mr-2"
+                >$ayiFan</v-icon
+              >
               {{ $ay.t("WorkOrderItemUnitList") }}
               <v-btn v-if="!parentDeleted" large icon v-bind="attrs" v-on="on">
                 <v-icon small color="primary">$ayiEllipsisV</v-icon>
@@ -35,7 +37,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template v-if="hasData">
         <!-- ############################################################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -57,8 +59,7 @@
           >
           </v-data-table>
         </v-col>
-      </template>
-      <template v-if="activeItemIndex != null">
+
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -450,8 +451,8 @@ export default {
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value.items[this.activeWoItemIndex].units.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
     canAdd: function() {
       return this.pvm.rights.change && this.pvm.subRights.units.create;
diff --git a/ayanova/src/components/work-order-items.vue b/ayanova/src/components/work-order-items.vue
index e5863301..309b9458 100644
--- a/ayanova/src/components/work-order-items.vue
+++ b/ayanova/src/components/work-order-items.vue
@@ -6,7 +6,9 @@
         <v-menu offset-y>
           <template v-slot:activator="{ on, attrs }">
             <div class="text-h5">
-              <v-icon x-large color="primary" class="mr-2">$ayiWrench</v-icon>
+              <v-icon x-large :color="hasData ? 'primary' : null" class="mr-2"
+                >$ayiWrench</v-icon
+              >
               {{ $ay.t("WorkOrderItemList") }}
               <v-btn large icon v-bind="attrs" v-on="on">
                 <v-icon small color="primary">$ayiEllipsisV</v-icon>
@@ -37,7 +39,7 @@
         </v-menu>
       </v-col>
 
-      <template v-if="showTable">
+      <template>
         <!-- ################################ WORK ORDER ITEMS TABLE ############################### -->
         <v-col cols="12" class="mb-10">
           <v-data-table
@@ -82,7 +84,7 @@
           </v-data-table>
         </v-col>
       </template>
-      <template v-if="activeItemIndex != null">
+      <template v-if="hasData">
         <v-btn
           v-if="canDelete && isDeleted"
           large
@@ -816,9 +818,10 @@ and it's probably not a big list to fill anyway
     formCustomTemplateKey: function() {
       return this.pvm.formCustomTemplateKey;
     },
-    showTable: function() {
-      return this.value && this.value.items && this.value.items.length > 1;
+    hasData: function() {
+      return this.activeItemIndex != null;
     },
+
     canAdd: function() {
       return (
         !this.pvm.formState.readOnly &&