From 4c95158a8ab82e81b9e1ea05d353fff601bf5258 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Tue, 25 Jan 2022 00:24:12 +0000 Subject: [PATCH] --- ayanova/devdocs/todo.txt | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt index 6d1f2d6b..15bf33bf 100644 --- a/ayanova/devdocs/todo.txt +++ b/ayanova/devdocs/todo.txt @@ -256,16 +256,7 @@ TODO: 1 BETA DOCS: - 1 todo: *** BIG one: the formfieldreference.cs file at the server end does *NOT* always use the exact model property names in the FieldKey property. - this is a huge issue because it breaks custom field required validation, the server just bombs on that becuase it can't find the property on the model - Unfortunately the client uses the same field name in it's v-if to hide or show fields so there are three things that need to be done here: - - - go through line by line and Ensure FormFieldREference uses the Actual Model property name exactly as it is defined - probably a hint this is not correct is if the fieldkey and the TKey are exactly the same - When a mismatch is found fix it at the server and also fix it at the client - At the client end change the v-if to use the same value (note that error handling etc already uses proper model names, this is just the v-if hide or show) - probably have to search globally because the same thing could be in use in multiple forms, will get a rythm for this when I get there - - At the server in RequiredFieldsValidator.cs wrap line 87 and maybe the above in a try catch block to properly handle and issue an error if the names don't match - rather than bombing. maybe do this first so can catch the ones that slip through +I've done the *Orders but nothing else other than a quick check of customer, so need to do other forms still TODO ACTUAL FOR THIS Errors returned *MUST* always be the model property because the server and biz rules will always use that, currently when I started to change it I didn't realize how important that was and @@ -277,7 +268,6 @@ TODO: 1 BETA DOCS: - 1 todo: Search limited to a type is *not* working, it just returns all results, search from a Customer for example and you will see all object results -- 1 todo: - 1 todo: time control in native browser format isn't showing a title at all, check date as well. Date and time is ok - 1 todo: help about does it show user has native date time input use browser override?