From 4c086cfe0d5c5baec7cb113cf001f8796ad06ee8 Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Wed, 2 Jun 2021 22:59:46 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt                      | 19 ++++++++++++++++---
 .../src/components/work-order-item-parts.vue  | 12 +++++++++---
 ayanova/src/components/work-order-items.vue   |  3 ++-
 ayanova/src/views/svc-workorder.vue           |  3 +++
 4 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index 15442cdc..d5de5dd1 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -361,13 +361,26 @@ CURRENTLY DOING: workorder round two electric boogaloo
 	basics first then increasingly esoteric features	
 
 Biggies
-todo 3: actual inventory (see below)
+todo 3: actual inventory 
 	1961 / 3752- auto remove from inventory immediately when wo saved and re-instate if changed
 		see PO back end for example of exactly this
+	SEEDER
+		make sure generated inventory and workorders are going to work with enough quantity etc
 todo: No inventory setting	*IMPORTANT* must test with inventory turned off for this and for PO system as well or whatever is necessary
 		make it work like v7
-todo 3: service bank (see below)
-todo 3: notification (see below)
+			NOTE: In v7 selecting serial copied to description field for some reason, but v8 has dedicated serial field so this is probably an import issue i.e. make sure import copies serials to serials 
+	
+		NEED:
+			on WO must hide all serial number selection elements if useinventory is off
+				but it seems reasonable to leave the field to just hand enter them in if desired
+			WO part selection: if useinventory then must run CheckIfEnoughInventory and offer to request or set to zero
+				in v7 when useinventory=true you cannot enter a quantity that is more than is in stock, you either initiate a request or it sets it to zero and won't allow any other value
+				so this must be replicated in v8 exactly and dynamically, not from server itself, but server must still check at last moment of save and return error if unavailable
+				See v7 project workorderform.cs line 8878 for the code in question
+
+
+todo 3: service bank
+todo 3: notification
 
 todo 3: signature: report helper display signature and form ui control to capture /display signature 
 	for both tech and customer
diff --git a/ayanova/src/components/work-order-item-parts.vue b/ayanova/src/components/work-order-item-parts.vue
index 00b08f1f..352d453c 100644
--- a/ayanova/src/components/work-order-item-parts.vue
+++ b/ayanova/src/components/work-order-item-parts.vue
@@ -148,7 +148,10 @@
         </v-col>
 
         <v-col
-          v-if="form().showMe(this, 'WorkOrderItemPartPartWarehouseID')"
+          v-if="
+            pvm.useInventory &&
+              form().showMe(this, 'WorkOrderItemPartPartWarehouseID')
+          "
           cols="12"
           sm="6"
           lg="4"
@@ -387,7 +390,7 @@ export default {
         description: null,
         serials: null,
         partId: null,
-        partWarehouseId: null,
+        partWarehouseId: 1, //important always default to "default" warehouse id 1 as even with inventory turned off it's required
         quantity: 1,
         taxPartSaleId: null,
         price: 0,
@@ -495,7 +498,10 @@ export default {
         });
       }
 
-      if (this.form().showMe(this, "WorkOrderItemPartPartWarehouseID")) {
+      if (
+        this.pvm.useInventory &&
+        this.form().showMe(this, "WorkOrderItemPartPartWarehouseID")
+      ) {
         headers.push({
           text: this.$ay.t("WorkOrderItemPartPartWarehouseID"),
           align: "left",
diff --git a/ayanova/src/components/work-order-items.vue b/ayanova/src/components/work-order-items.vue
index e79d1fe5..df9dbdcc 100644
--- a/ayanova/src/components/work-order-items.vue
+++ b/ayanova/src/components/work-order-items.vue
@@ -428,7 +428,8 @@
         <v-col
           cols="12"
           v-if="
-            value.items[activeItemIndex].partRequests.length > 0 &&
+            pvm.useInventory &&
+              value.items[activeItemIndex].partRequests.length > 0 &&
               pvm.subRights.partRequests.visible &&
               form().showMe(this, 'WorkOrderItemPartRequestList')
           "
diff --git a/ayanova/src/views/svc-workorder.vue b/ayanova/src/views/svc-workorder.vue
index 4dd67811..a58d5f9b 100644
--- a/ayanova/src/views/svc-workorder.vue
+++ b/ayanova/src/views/svc-workorder.vue
@@ -327,6 +327,9 @@ export default {
         completed: false,
         locked: false
       };
+    },
+    useInventory() {
+      return window.$gz.store.state.globalSettings.useInventory;
     }
   },
   methods: {