diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt index 4408b4f2..ecce925e 100644 --- a/ayanova/devdocs/todo.txt +++ b/ayanova/devdocs/todo.txt @@ -423,7 +423,7 @@ todo: many biz objects are not using new PUT methodology CURRENTLY DOING: -todo: looks like wont' need subrights system, need to disentangle and remove it from workorder + todo: Status on work order doesn't seem to be preventing "Who can select" by role properly Make it not present status that are not supposed to be available put a back end rule in validation to prevent it as well diff --git a/ayanova/src/components/work-order-header.vue b/ayanova/src/components/work-order-header.vue index 21190cf2..779b1deb 100644 --- a/ayanova/src/components/work-order-header.vue +++ b/ayanova/src/components/work-order-header.vue @@ -61,8 +61,7 @@ 0 && !this.value.userIsSubContractorRestricted @@ -1304,42 +1300,36 @@ and it's probably not a big list to fill anyway }, canAddScheduledUser: function() { return ( - this.pvm.subRights.scheduledUsers.create && this.form().showMe(this, "WorkOrderItemScheduledUserList") && !this.value.userIsRestrictedType ); }, showScheduledUsers: function() { return ( - this.pvm.subRights.scheduledUsers.visible && this.form().showMe(this, "WorkOrderItemScheduledUserList") && this.value.items[this.activeItemIndex].scheduledUsers.length > 0 ); }, canAddTask: function() { return ( - this.pvm.subRights.tasks.create && this.form().showMe(this, "WorkOrderItemTasks") && !this.value.userIsRestrictedType ); }, showTasks: function() { return ( - this.pvm.subRights.tasks.visible && this.form().showMe(this, "WorkOrderItemTasks") && this.value.items[this.activeItemIndex].tasks.length > 0 ); }, canAddPart: function() { return ( - this.pvm.subRights.parts.create && this.form().showMe(this, "WorkOrderItemPartList") && !this.value.userIsRestrictedType ); }, showParts: function() { return ( - this.pvm.subRights.parts.visible && this.form().showMe(this, "WorkOrderItemPartList") && this.value.items[this.activeItemIndex].parts.length > 0 && !this.value.userIsSubContractorRestricted @@ -1349,41 +1339,31 @@ and it's probably not a big list to fill anyway return ( this.pvm.useInventory && this.value.items[this.activeItemIndex].partRequests.length > 0 && - this.pvm.subRights.partRequests.visible && this.form().showMe(this, "WorkOrderItemPartRequestList") && !this.value.userIsSubContractorRestricted ); }, canAddLabor: function() { - return ( - this.pvm.subRights.labors.create && - this.form().showMe(this, "WorkOrderItemLaborList") - ); + return this.form().showMe(this, "WorkOrderItemLaborList"); }, showLabors: function() { return ( - this.pvm.subRights.labors.visible && this.form().showMe(this, "WorkOrderItemLaborList") && this.value.items[this.activeItemIndex].labors.length > 0 ); }, canAddTravel: function() { - return ( - this.pvm.subRights.travels.create && - this.form().showMe(this, "WorkOrderItemTravelList") - ); + return this.form().showMe(this, "WorkOrderItemTravelList"); }, showTravels: function() { return ( - this.pvm.subRights.travels.visible && this.form().showMe(this, "WorkOrderItemTravelList") && this.value.items[this.activeItemIndex].travels.length > 0 ); }, canAddExpense: function() { return ( - this.pvm.subRights.expenses.create && this.form().showMe(this, "WorkOrderItemExpenseList") && !this.value.userIsSubContractorFull && !this.value.userIsSubContractorRestricted @@ -1391,7 +1371,6 @@ and it's probably not a big list to fill anyway }, showExpenses: function() { return ( - this.pvm.subRights.expenses.visible && this.form().showMe(this, "WorkOrderItemExpenseList") && this.value.items[this.activeItemIndex].expenses.length > 0 && !this.value.userIsSubContractorFull && @@ -1400,14 +1379,12 @@ and it's probably not a big list to fill anyway }, canAddLoan: function() { return ( - this.pvm.subRights.loans.create && this.form().showMe(this, "WorkOrderItemLoanList") && !this.value.userIsRestrictedType ); }, showLoans: function() { return ( - this.pvm.subRights.loans.visible && this.form().showMe(this, "WorkOrderItemLoanList") && this.value.items[this.activeItemIndex].loans.length > 0 && !this.value.userIsSubContractorRestricted @@ -1415,14 +1392,12 @@ and it's probably not a big list to fill anyway }, canAddOutsideService: function() { return ( - this.pvm.subRights.outsideServices.create && this.form().showMe(this, "WorkOrderItemOutsideServiceList") && !this.value.userIsRestrictedType ); }, showOutsideServices: function() { return ( - this.pvm.subRights.outsideServices.visible && this.form().showMe(this, "WorkOrderItemOutsideServiceList") && this.value.items[this.activeItemIndex].outsideServices.length > 0 && !this.value.userIsRestrictedType diff --git a/ayanova/src/components/work-order-state.vue b/ayanova/src/components/work-order-state.vue index fea7cf94..77964aa8 100644 --- a/ayanova/src/components/work-order-state.vue +++ b/ayanova/src/components/work-order-state.vue @@ -267,7 +267,7 @@ export default { }, canAdd: function() { //first check most obvious disqualifying properties - if (!this.pvm.rights.change || !this.pvm.subRights.states.create) { + if (!this.pvm.rights.change) { return false; } diff --git a/ayanova/src/views/svc-workorder.vue b/ayanova/src/views/svc-workorder.vue index abf29fd9..9ff42f58 100644 --- a/ayanova/src/views/svc-workorder.vue +++ b/ayanova/src/views/svc-workorder.vue @@ -220,7 +220,7 @@ export default { appError: null, serverError: {} }, - rights: window.$gz.role.defaultRightsObject(), //overall workorder rights, supersedes subrights + rights: window.$gz.role.defaultRightsObject(), ayaType: window.$gz.type.WorkOrder, currencyName: window.$gz.locale.getCurrencyName(), timeZoneName: window.$gz.locale.getResolvedTimeZoneName(), @@ -235,79 +235,6 @@ export default { woItemTaskCompletionTypes: [], loanUnitRateUnits: [] }, - subRights: { - items: { - visible: true, - create: true, - change: true, - delete: true - }, - states: { - visible: true, - create: true, //no change, only create it's write only - delete: true - }, - labors: { - visible: true, - create: true, - change: true, - delete: true - }, - parts: { - visible: true, - create: true, - change: true, - delete: true - }, - partRequests: { - visible: true, - create: true, - change: true, - delete: true - }, - expenses: { - visible: true, - create: true, - change: true, - delete: true - }, - loans: { - visible: true, - create: true, - change: true, - delete: true - }, - scheduledUsers: { - visible: true, - create: true, - change: true, - delete: true - }, - tasks: { - visible: true, - create: true, - change: true, - delete: true - }, - travels: { - visible: true, - create: true, - change: true, - delete: true - }, - units: { - visible: true, - create: true, - change: true, - delete: true - }, - outsideServices: { - visible: true, - create: true, - change: true, - delete: true - } - }, maxTableNotesLength: 50, //value to cut off notes in tables saveResult: { fatal: false, //fatal error, further save is pointless, bail early and report