From 44456b9df3715f6447d221630f1efb53f4326cfd Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Tue, 23 Nov 2021 00:41:38 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt                       | 18 ++++++++++--------
 ayanova/src/components/pm-item-parts.vue       |  6 ++----
 .../src/components/work-order-item-parts.vue   |  6 ++----
 ayanova/src/views/inv-purchase-order.vue       |  1 +
 4 files changed, 15 insertions(+), 16 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index bb0f2eb1..01a11bc5 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -25,14 +25,10 @@
 Currently doing global settings doc page, but should probably move to below items first for joyce then back to doc page
 
 
-todo: Urgent - combine part number / name into single Name field, translate as "Part" simply and use key PartName still
-	there is a case (maybe 4025) about this and thoughts on how to migrate etc
-	BROKEN ITEMS:
-		workorder item parts shows name in wrong place and empty part column, probably quote and pm as well
-
-
-todo: alternateive to "zExampleReport" naming to push to bottom, find out of can ditch the z for something nicer like a unicode symbol or emoji or whatever appears at end and isn't a z
-	Use lightbulb symbol emoji 💡
+todo: v8Migrate add UI for part number / name migration options
+	two options: PartNumber, PartName to combined v8 PartName field or PartNumber to PartName and PartName to PartDescription
+	add code to migrate accordingly
+	also log the choices made in the pre-migrate options form so they are visible to the log
 
 
 todo: cases for csr and for wo
@@ -969,3 +965,9 @@ BUILD 139 CHANGES OF NOTE
 	Also recommend drop the word "EXAMPLE" or if you feel it must be there to make it the final word in the name so that people can see the relevant bits sooner
 	Also recommend remove any words that redundantly refer to the object type i.e. no need to put "Customer" in a Customer report unless it's necessary
 	e.g. "EXAMPLE single line per PO" becomes "💡 Single line per PO" or "💡 Single line per PO example"
+
+- case 4028 see case
+- case 4029 fixed
+- case 4030 see case notes
+- case 4031 done
+- case 4032 see case notes
\ No newline at end of file
diff --git a/ayanova/src/components/pm-item-parts.vue b/ayanova/src/components/pm-item-parts.vue
index 7d31d08d..d0bfdd59 100644
--- a/ayanova/src/components/pm-item-parts.vue
+++ b/ayanova/src/components/pm-item-parts.vue
@@ -266,10 +266,6 @@
               form().decimalValid(
                 this,
                 `Items[${activeWoItemIndex}].parts[${activeItemIndex}].suggestedQuantity`
-              ),
-              form().required(
-                this,
-                `Items[${activeWoItemIndex}].parts[${activeItemIndex}].suggestedQuantity`
               )
             ]"
             @input="
@@ -655,6 +651,7 @@ export default {
             partId: z.partId,
             partWarehouseId: this.selectedPartWarehouse,
             quantity: z.quantity,
+            suggestedQuantity: 0,
             taxPartSaleId:
               window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
             price: 0,
@@ -765,6 +762,7 @@ export default {
         partId: 0, //deliberately zero to break rule on new
         partWarehouseId: 1, //important always default to "default" warehouse id 1 as even with inventory turned off it's required
         quantity: 1,
+        suggestedQuantity: 0,
         taxPartSaleId:
           window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
         price: 0,
diff --git a/ayanova/src/components/work-order-item-parts.vue b/ayanova/src/components/work-order-item-parts.vue
index e7ef7125..9a3afc62 100644
--- a/ayanova/src/components/work-order-item-parts.vue
+++ b/ayanova/src/components/work-order-item-parts.vue
@@ -277,10 +277,6 @@
               form().decimalValid(
                 this,
                 `Items[${activeWoItemIndex}].parts[${activeItemIndex}].suggestedQuantity`
-              ),
-              form().required(
-                this,
-                `Items[${activeWoItemIndex}].parts[${activeItemIndex}].suggestedQuantity`
               )
             ]"
             @input="
@@ -677,6 +673,7 @@ export default {
             partId: z.partId,
             partWarehouseId: this.selectedPartWarehouse,
             quantity: z.quantity,
+            suggestedQuantity: 0,
             taxPartSaleId:
               window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
             price: 0,
@@ -785,6 +782,7 @@ export default {
         partId: 0, //deliberately zero to break rule on new
         partWarehouseId: 1, //important always default to "default" warehouse id 1 as even with inventory turned off it's required
         quantity: 1,
+        suggestedQuantity: 0,
         taxPartSaleId:
           window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
         price: 0,
diff --git a/ayanova/src/views/inv-purchase-order.vue b/ayanova/src/views/inv-purchase-order.vue
index 9045fa30..c5e4773b 100644
--- a/ayanova/src/views/inv-purchase-order.vue
+++ b/ayanova/src/views/inv-purchase-order.vue
@@ -1905,6 +1905,7 @@ async function fetchTranslatedText(vm) {
     "PurchaseOrderItemQuantityReceived",
     "Part",
     "PartName",
+    "PartUPC",
     "PartDescription",
     "PartWarehouse",
     "TaxCode",