This commit is contained in:
2020-10-13 20:48:49 +00:00
parent ec7858508f
commit 3173d8889c
4 changed files with 2 additions and 37 deletions

View File

@@ -3,30 +3,6 @@
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
To try:
msft pwa stuff
It uses one of the additional icon24 or 48 for the task bar icon when running as an app
still has the 16px tiny one on the desktop
android from chrome is white background
android from ff is same color green as the shirt background! fuck!
maybe becuase it doesn't have a "maskable icon" see below
remove the favico.ico completely as a test
todo: needs a maskable icon according to lighthouse:
The icons array must contain one object with a purpose property, and the value of that purpose property must include maskable.
https://web.dev/maskable-icon/
todo: for some reason the 32px icon is being surrounded by an if statement in the generated index.html page in dist folder
I think I tried commenting out the 32bit null one to see what would happen but haven't built yet to compare
May require a manual step for release of removing the comment if I can't find a way to turn that shit off, no idea what part of the build process is responsible, maybe workbox stuff?
TODO: tiny icon used in windows when chrome install to desktop used
Issue on github: https://github.com/RealFaviconGenerator/realfavicongenerator/issues/446
todo: figure out which tool and get rid of this added to index.html on build:
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
todo: service workers for monaco going in root of website folder, must be a config setting to move it into the proper place (not there)
couldn't find anything about it, may need to post to ask, it's not the end of the world but kind of stupid looking as all the rest of the js is in subfolder