admin/raven-client
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clean and on track

Browse Source
This commit is contained in:
John Cardinal
2021-04-16 23:43:52 +00:00
parent 1abc9b3cd1
commit 29d707d9df
3 changed files with 7 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
ayanova/devdocs/todo.txt
View File

@@ -236,26 +236,18 @@ todo: many biz objects are not using new PUT methodology
CURRENTLY DOING: save (and delete), then error handling (move to individual saves the formatting / compilation), then resume list CURRENTLY DOING: need to test save / delete and error handling on delete (in particular, already tested save), then can proceed
OVERALL OVERALL
ORDERING AND ERRORS
- WOITEMS NEED A GUARANTEED GOOD INDEX apart from all others
uiindex temporary value guaranteed to be unique (timestamp?)
- if woitem is flagged for delete all children should be as well
just flag them in the tree when the woitem is flagged toggle children
- SOFT DELETE ISSUE:
because it's removing the row on delete but not deleting until save, any errors can't be displayed correctly
TODO: move to a "soft delete" get rid of the deleted items separate array
- on save iterate the graph looking for deleted=true and attempt delete
- on fail of delete set deleted=true to false so it will show but make sure to do it *IN* the delete method so it's ready for later to show the error
- Clean up save error handling code and remove comments
- clean up delete code in schedusers if not already
- test partial save (### and delete ###) with fail at each level (make up a fail if have to at server) - test partial save (### and delete ###) with fail at each level (make up a fail if have to at server)
- Double check full delete still works
- make a new wo from scratch and test thoroughly
- double check mobile format view is still ok with errors and all
- Error messages should display correctly both in alert box and in each item's controls - Error messages should display correctly both in alert box and in each item's controls
- Decide on and implement "MARKED FOR DELETE" text that shows in sub items, it's just scaffolded in right now
perhaps a big red trashcan is adequate?? Although it doesn't really convey marked so much as being a control people will try to click on
- Test out role rights, login as various roles and ensure it works as expected - Test out role rights, login as various roles and ensure it works as expected
- once past this step then second pass at new features **that affect models** (not necessarily UI stuff just fields required etc) - once past this step then second pass at new features **that affect models** (not necessarily UI stuff just fields required etc)
Add items below that are just spurious and not tied to a particular case as v.next cases YAGNI/TTM! Add items below that are just spurious and not tied to a particular case as v.next cases YAGNI/TTM!

1
ayanova/src/components/work-order-item-scheduled-users.vue
View File

@@ -87,7 +87,6 @@
" "
></gz-decimal> ></gz-decimal>
</v-col> </v-col>
<!-- {{ value.items[activeWoItemIndex].scheduledUsers[activeItemIndex] }} -->
</template> </template>
</div> </div>
</template> </template>

13
ayanova/src/components/work-order-items.vue
View File

@@ -149,19 +149,8 @@ export default {
default: null, default: null,
type: Object type: Object
} }
// , resetSelections: {
// default: false,
// type: Boolean
// }
}, },
// watch: {
// resetSelections: function(newValue, oldValue) {
// if (newValue != oldValue) {
// // this.activeItemIndex = null;
// // this.selectedRow = [];
// }
// }
// },
methods: { methods: {
newItem() { newItem() {
let newIndex = this.value.items.length; let newIndex = this.value.items.length;