From 29d707d9dfb6e8231023c10a87e3cc937f158b4b Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Fri, 16 Apr 2021 23:43:52 +0000
Subject: [PATCH] clean and on track

---
 ayanova/devdocs/todo.txt                      | 20 ++++++-------------
 .../work-order-item-scheduled-users.vue       |  1 -
 ayanova/src/components/work-order-items.vue   | 13 +-----------
 3 files changed, 7 insertions(+), 27 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index 408e1c5d..99023297 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -236,26 +236,18 @@ todo: many biz objects are not using new PUT methodology
 
 
 
-CURRENTLY DOING: save (and delete), then error handling (move to individual saves the formatting / compilation), then resume list
+CURRENTLY DOING: need to test save / delete and error handling on delete (in particular, already tested save), then can proceed
 
 
 OVERALL	
-	ORDERING AND ERRORS	
-	- WOITEMS NEED A GUARANTEED GOOD INDEX apart from all others
-		uiindex temporary value guaranteed to be unique (timestamp?)
-	- if woitem is flagged for delete all children should be as well
-		just flag them in the tree when the woitem is flagged toggle children
-	- SOFT DELETE ISSUE: 
-		because it's removing the row on delete but not deleting until save, any errors can't be displayed correctly
-		TODO: move to a "soft delete" get rid of the deleted items separate array
-			
-			- on save iterate the graph looking for deleted=true and attempt delete
-			- on fail of delete set deleted=true to false so it will show but make sure to do it *IN* the delete method so it's ready for later to show the error
 
-	- Clean up save error handling code and remove comments
-	- clean up delete code in schedusers if not already	
 	- test partial save (### and delete ###) with fail at each level (make up a fail if have to at server)
+	- Double check full delete still works
+	- make a new wo from scratch and test thoroughly
+	- double check mobile format view is still ok with errors and all
 	- Error messages should display correctly both in alert box and in each item's controls
+	- Decide on and implement "MARKED FOR DELETE" text that shows in sub items, it's just scaffolded in right now
+		perhaps a big red trashcan is adequate??  Although it doesn't really convey marked so much as being a control people will try to click on 
 	- Test out role rights, login as various roles and ensure it works as expected
 	- once past this step then second pass at new features **that affect models** (not necessarily UI stuff just fields required etc)
 		Add items below that are just spurious and not tied to a particular case as v.next cases YAGNI/TTM!	
diff --git a/ayanova/src/components/work-order-item-scheduled-users.vue b/ayanova/src/components/work-order-item-scheduled-users.vue
index 509577e8..d90bc240 100644
--- a/ayanova/src/components/work-order-item-scheduled-users.vue
+++ b/ayanova/src/components/work-order-item-scheduled-users.vue
@@ -87,7 +87,6 @@
           "
         ></gz-decimal>
       </v-col>
-      <!-- {{ value.items[activeWoItemIndex].scheduledUsers[activeItemIndex] }} -->
     </template>
   </div>
 </template>
diff --git a/ayanova/src/components/work-order-items.vue b/ayanova/src/components/work-order-items.vue
index 0d783971..61bf8379 100644
--- a/ayanova/src/components/work-order-items.vue
+++ b/ayanova/src/components/work-order-items.vue
@@ -149,19 +149,8 @@ export default {
       default: null,
       type: Object
     }
-    // ,    resetSelections: {
-    //   default: false,
-    //   type: Boolean
-    // }
   },
-  // watch: {
-  //   resetSelections: function(newValue, oldValue) {
-  //     if (newValue != oldValue) {
-  //       // this.activeItemIndex = null;
-  //       // this.selectedRow = [];
-  //     }
-  //   }
-  // },
+
   methods: {
     newItem() {
       let newIndex = this.value.items.length;