From 1d7908667b7d6ea77e5f16f38a09ad94b96fd4eb Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Mon, 3 Jan 2022 17:40:47 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt              |  4 +---
 ayanova/src/components/data-table.vue | 13 +++++++++++--
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index ecbde213..79e6e203 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -244,9 +244,6 @@ TODO: 1 BETA DOCS:
                                            
 
 
-- 1 bugbug: SERIOUS BUG when testing reporting load test, one time selected a few specific wo from list to confirm it could still report properly after fail due to oom
-	then filtered for less recs and reran report and got selected ones only even though not selected
-	appears in some circs is selection not resetting in data table or in printing code??
 
 - 1 todo: figure out why a wait display in clien tpage (printing for eg) causes the browser to go wild using up cpu cycles, like WTF is that about
 	animation, graphics, ???
@@ -849,6 +846,7 @@ Current v8 docs home: https://www.ayanova.com/docs/
 BUILD 8.0.0-beta.0.9 CHANGES OF NOTE
 
 - Upgraded Windows Standalone version of PostgresSQL to 14.1 from 14.0
+- data table now clears selected records array properly when change or remove filter and also when deselect all from the select all checkbox at top
 
 
 
diff --git a/ayanova/src/components/data-table.vue b/ayanova/src/components/data-table.vue
index b26c6249..b2787781 100644
--- a/ayanova/src/components/data-table.vue
+++ b/ayanova/src/components/data-table.vue
@@ -1,7 +1,6 @@
 <template>
   <div>
     <gz-error :error-box-message="formState.errorBoxMessage"></gz-error>
-
     <gz-data-table-filter
       :data-list-key="dataListKey"
       :active-filter-id="activeFilterId"
@@ -113,6 +112,7 @@
           :no-data-text="$ay.t('NoData')"
           class="elevation-1"
           data-cy="datatable"
+          @toggle-select-all="selectAll"
         >
           <!-- HEADER FILTERS: https://stackoverflow.com/a/58718975/8939 -->
           <template v-for="h in headers" v-slot:[`header.${h.value}`]>
@@ -320,6 +320,7 @@
           class="elevation-1"
           data-cy="datatable"
           :no-data-text="$ay.t('NoData')"
+          @toggle-select-all="selectAll"
         >
           <template v-slot:body="{ items }">
             <v-row>
@@ -675,6 +676,7 @@ export default {
     async filter(item) {
       const res = await this.$refs.dataTableFilter.open(item);
       if (res && res.refresh == true) {
+        this.selected = []; //remove any selections
         //New filter, need to go back to the first page
         this.dataTablePagingOptions.page = 1;
         this.getDataFromApi();
@@ -688,6 +690,7 @@ export default {
       return clr;
     },
     async clearFilter(reloadData) {
+      this.selected = [];
       //Reset back to DEFAULT filter
       setActiveFilter(this); //will not trigger refresh yet
 
@@ -794,9 +797,14 @@ export default {
         )
       };
     },
+    selectAll(event) {
+      //deselect all, fixes an issue where a deep selection not visible is not cleared otherwise
+      if (event.value == false) {
+        this.selected = [];
+      }
+    },
     handleSelectChange() {
       //SINGLESELECT MODE?
-      //due to making own template for items need to handle singleselect which only affects if select all checkbox at top is visible when making own item template
       if (this.singleSelect) {
         this.selected.splice(0, this.selected.length - 1);
       }
@@ -817,6 +825,7 @@ export default {
       });
     },
     selectedFilterChanged: async function() {
+      this.selected = [];
       await this.getDataFromApi();
     },
     gridCellButtonClick(key, i, ot) {